Subj : Static code analysis
To   : Michael Pierce
From : Michael Dukelsky
Date : Wed Feb 17 2021 09:36:22

Hello Michael,

Tuesday February 16 2021, Michael Pierce wrote to Michael Dukelsky:

 MD>> I've started using static code analysis for improving the code.
 MD>> At the moment I've applied the static analysis to huskylib and
 MD>> smapi and pushed the results to the master branch. I tested
 MD>> compilation in Windows using Visual Studio 2019 and in linux
 MD>> using gcc 10.2.1. Please check whether it compiles in OS/2.

 MP> when you say master branch, where do you mean??

I mean master branch in the repository.

$ git status
On branch master
   ^^^^^^^^^^^^^ This is the branch in my local repository which I cloned
                 from github.
Your branch is up to date with 'origin/master'.
                                ^^^^^^^^^^^^^
                 And this is the same branch in the remote repository on
                 github.

I did development in a separate temporary branch. After finishing I merged the temporary branch with the master branch, so that all the made changes are now in the master branch. And then I deleted the temporary branch.

 MP> I got the following to compile:
 MP> https://github.com/zoomosis/huskylib
 MP> https://github.com/zoomosis/smapi
 MP> https://github.com/zoomosis/fidoconf
 MP> https://github.com/zoomosis/areafix

 MP> but hpt did not
 MP> here is the output of wmake

 MP> Open Watcom Make Version 2.0beta1 Limited Availability
 MP> Portions Copyright (c) 1988-2002 Sybase, Inc. All Rights Reserved.
 MP> Source code is available under the Sybase Open Watcom Public License.
 MP> See http://www.openwatcom.org/ for details.
 MP>         wcl386 -zq -bt=os2v2 -l=os2v2 -I..\h -I..\..\huskylib
 MP> -I..\..\fidoconf -I..\..\smapi -I..\..\areafix -Fe=pktinfo.exe
 MP> ..\src\pktinfo.c ..\src\dupe.c ..\src\pktread.c ..\src\fcommon.c
 MP> ..\src\global.c ..\..\huskylib\make\huskywco.lib
 MP> ..\..\fidoconf\make\fconfwco.lib ..\..\smapi\make\smapiwco.lib
 MP> ..\..\areafix\make\afixwco.lib Error! E2028: gettimeofday_ is an
 MP> undefined reference file
 MP> ..\..\huskylib\make\huskywco.lib(C:\home\src\husky\huskylib\src\tdelay
 MP> .c): undefined symbol gettimeofday_
 MP> Error: Linker returned a bad status

gettimeofday should be in libc. Maybe OS/2 users may help you.

Michael

.... node (at) f1042 (dot) ru
--- GoldED+/LNX 1.1.5-b20180707
 * Origin: Moscow, Russia (2:5020/1042)

.