Subj : Static code analysis To : Michael Dukelsky From : Michael Pierce Date : Tue Feb 16 2021 16:17:44 Hello Michael! 15 Feb 21 18:26, you wrote to all: MD> Hello All, MD> I've started using static code analysis for improving the code. At the MD> moment I've applied the static analysis to huskylib and smapi and MD> pushed the results to the master branch. I tested compilation in MD> Windows using Visual Studio 2019 and in linux using gcc 10.2.1. Please MD> check whether it compiles in OS/2. when you say master branch, where do you mean?? I got the following to compile: https://github.com/zoomosis/huskylib https://github.com/zoomosis/smapi https://github.com/zoomosis/fidoconf https://github.com/zoomosis/areafix but hpt did not here is the output of wmake Open Watcom Make Version 2.0beta1 Limited Availability Portions Copyright (c) 1988-2002 Sybase, Inc. All Rights Reserved. Source code is available under the Sybase Open Watcom Public License. See http://www.openwatcom.org/ for details. wcl386 -zq -bt=os2v2 -l=os2v2 -I..\h -I..\..\huskylib -I..\..\fidoconf -I..\..\smapi -I..\..\areafix -Fe=pktinfo.exe ..\src\pktinfo.c ..\src\dupe.c ..\src\pktread.c ..\src\fcommon.c ..\src\global.c ..\..\huskylib\make\huskywco.lib ..\..\fidoconf\make\fconfwco.lib ..\..\smapi\make\smapiwco.lib ..\..\areafix\make\afixwco.lib Error! E2028: gettimeofday_ is an undefined reference file ..\..\huskylib\make\huskywco.lib(C:\home\src\husky\huskylib\src\tdelay.c): undefined symbol gettimeofday_ Error: Linker returned a bad status wcl386 -zq -bt=os2v2 -l=os2v2 -I..\h -I..\..\huskylib -I..\..\fidoconf -I..\..\smapi -I..\..\areafix -Fe=tpkt.exe ..\src\tpkt.c ..\src\global.c ..\src\pktread.c ..\src\pktwrite.c ..\src\fcommon.c ..\src\dupe.c ..\..\huskylib\make\huskywco.lib ..\..\fidoconf\make\fconfwco.lib ..\..\smapi\make\smapiwco.lib ..\..\areafix\make\afixwco.lib Error! E2028: gettimeofday_ is an undefined reference file ..\..\huskylib\make\huskywco.lib(C:\home\src\husky\huskylib\src\tdelay.c): undefined symbol gettimeofday_ Error: Linker returned a bad status wcl386 -zq -bt=os2v2 -l=os2v2 -I..\h -I..\..\huskylib -I..\..\fidoconf -I..\..\smapi -I..\..\areafix -Fe=txt2pkt.exe ..\src\txt2pkt.c ..\src\global.c ..\src\pktread.c ..\src\pktwrite.c ..\src\fcommon.c ..\src\dupe.c ..\..\huskylib\make\huskywco.lib ..\..\fidoconf\make\fconfwco.lib ..\..\smapi\make\smapiwco.lib ..\..\areafix\make\afixwco.lib Error! E2028: gettimeofday_ is an undefined reference file ..\..\huskylib\make\huskywco.lib(C:\home\src\husky\huskylib\src\tdelay.c): undefined symbol gettimeofday_ Error: Linker returned a bad status wcl386 -zq -bt=os2v2 -l=os2v2 -I..\h -I..\..\huskylib -I..\..\fidoconf -I..\..\smapi -I..\..\areafix -Fe=hptlink.exe ..\src\hptlink.c ..\src\global.c ..\..\huskylib\make\huskywco.lib ..\..\fidoconf\make\fconfwco.lib ..\..\smapi\make\smapiwco.lib ..\..\areafix\make\afixwco.lib ...\src\hptlink.c(657): Warning! W136: Comparison equivalent to 'unsigned == 0' ...\src\hptlink.c(671): Warning! W136: Comparison equivalent to 'unsigned == 0' Warning! W1027: file global.obj(C:\home\src\husky\hpt\src\global.c): redefinition of _config ignored Warning! W1027: file global.obj(C:\home\src\husky\hpt\src\global.c): redefinition of _versionStr ignored Error! E2028: gettimeofday_ is an undefined reference file ..\..\huskylib\make\huskywco.lib(C:\home\src\husky\huskylib\src\tdelay.c): undefined symbol gettimeofday_ Error: Linker returned a bad status wcl386 -zq -bt=os2v2 -l=os2v2 -I..\h -I..\..\huskylib -I..\..\fidoconf -I..\..\smapi -I..\..\areafix -Fe=hpttree.exe ..\src\hpttree.c ..\..\huskylib\make\huskywco.lib ..\..\fidoconf\make\fconfwco.lib ..\..\smapi\make\smapiwco.lib ..\..\areafix\make\afixwco.lib Error! E2028: gettimeofday_ is an undefined reference file ..\..\huskylib\make\huskywco.lib(C:\home\src\husky\huskylib\src\tdelay.c): undefined symbol gettimeofday_ Error: Linker returned a bad status wcl386 -zq -bt=os2v2 -l=os2v2 -I..\h -I..\..\huskylib -I..\..\fidoconf -I..\..\smapi -I..\..\areafix -Fe=hpt.exe ..\src\hpt.c ..\src\global.c ..\src\pktread.c ..\src\pktwrite.c ..\src\fcommon.c ..\src\toss.c ..\src\scan.c ..\src\scanarea.c ..\src\post.c ..\src\hptafix.c ..\src\dupe.c ..\src\seenby.c ..\src\link.c ..\src\carbon.c ..\..\huskylib\make\huskywco.lib ..\..\fidoconf\make\fconfwco.lib ..\..\smapi\make\smapiwco.lib ..\..\areafix\make\afixwco.lib ...\src\toss.c(3204): Warning! W1181: Parameter 1, sign specifier mismatch ...\src\toss.c(3204): Note! N2003: source conversion type is 'unsigned long *' ...\src\toss.c(3204): Note! N2004: target conversion type is 'long *' ...\src\toss.c(3218): Warning! W1181: Parameter 1, sign specifier mismatch ...\src\toss.c(3218): Note! N2003: source conversion type is 'unsigned long *' ...\src\toss.c(3218): Note! N2004: target conversion type is 'long *' ...\src\toss.c(3230): Warning! W1181: Parameter 1, sign specifier mismatch ...\src\toss.c(3230): Note! N2003: source conversion type is 'unsigned long *' ...\src\toss.c(3230): Note! N2004: target conversion type is 'long *' Error! E2028: gettimeofday_ is an undefined reference file ..\..\huskylib\make\huskywco.lib(C:\home\src\husky\huskylib\src\tdelay.c): undefined symbol gettimeofday_ Error: Linker returned a bad status Thanks, Michael --- GoldED+/LNX 1.1.5-b20180707 * Origin: Our Awesome Net - Portland, OR - awesome.abon.us (1:105/81) .