Subj : Squish __ftsc_date bug / JAM bug
To   : andrew clarke
From : Michael Dukelsky
Date : Sun Feb 14 2021 22:50:12

Hello andrew,

Sunday February 14 2021, andrew clarke wrote to Oli:

 ac> api_jam.c:JamReadMsg() has this:

 ac>         scombo = (SCOMBO *)(&(msg->date_written));
 ac>         scombo = TmDate_to_DosDate(s_time, scombo);
 ac>         /* ftsdate = msg->__ftsc_date; */
 ac>         ftsdate = (unsigned char *)sc_time(scombo, (char
 ac> *)(msg->__ftsc_date));

 ac> But maybe the correct code should be:

 ac>         if (*msg->__ftsc_date)
 ac>         {
 ac>             ftsdate = msg->__ftsc_date;
 ac>         }
 ac>         else
 ac>         {
 ac>             scombo = (SCOMBO *)(&(msg->date_written));
 ac>             scombo = TmDate_to_DosDate(s_time, scombo);
 ac>             ftsdate = (unsigned char *)sc_time(scombo, (char
 ac> *)(msg->__ftsc_date));
 ac>         }

"ftsdate" variable is assigned but it is never used, so I've already commented it out but not in master branch yet.

Michael

.... node (at) f1042 (dot) ru
--- GoldED+/LNX 1.1.5-b20180707
 * Origin: Moscow, Russia (2:5020/1042)

.