Subj : Squish __ftsc_date bug / JAM bug
To   : Oli
From : andrew clarke
Date : Sun Feb 14 2021 23:44:06

14 Feb 21 11:28, you wrote to me:

 Ol> I tested it with a JAM base and it still works. But it turned out a
 Ol> rescan from a JAM base also modifies time stamps:

 Ol> Original:
 Ol> Date and time      : 09 Feb 21  06:31:33

 Ol> After rescan from JAM:
 Ol> Date and time      : 09 Feb 21  06:31:32

 Ol> Which means Squish can be fixed, but JAM has the same problem (I tested
 Ol> JAM with hpt from github master without any patch).

 Ol> Maybe a problem/bug within SMAPI (JAM jammed into the Squish API)?

api_jam.c:JamReadMsg() has this:

        scombo = (SCOMBO *)(&(msg->date_written));
        scombo = TmDate_to_DosDate(s_time, scombo);
        /* ftsdate = msg->__ftsc_date; */
        ftsdate = (unsigned char *)sc_time(scombo, (char *)(msg->__ftsc_date));

But maybe the correct code should be:

        if (*msg->__ftsc_date)
        {
            ftsdate = msg->__ftsc_date;
        }
        else
        {
            scombo = (SCOMBO *)(&(msg->date_written));
            scombo = TmDate_to_DosDate(s_time, scombo);
            ftsdate = (unsigned char *)sc_time(scombo, (char *)(msg->__ftsc_date));
        }

--- GoldED+/BSD 1.1.5-b20180707
 * Origin: Blizzard of Ozz, Melbourne, Victoria, Australia (3:633/267)

.