Subj : Re: JS_GC behaviour changed in rc5 ??? To : netscape.public.mozilla.jseng From : "Franky Braem" Date : Mon Feb 17 2003 08:07 pm Brendan, Just to tell you that the patch works! The memory leaks are gone. Franky. "Brendan Eich" wrote in message news:b2n01m$4bk1@ripley.netscape.com... > Franky Braem wrote: > > >"Brendan Eich" wrote in message > >news:3E428F85.7020506@meer.net... > > > > > > > >>It's quite possible something broke. Can you show a minimal test-app > >>(like a stripped down js.c) that demonstrates the problem you see in > >>rc5, that was not in rc4? Thanks. > >> > > > >That's going to be difficult. I only have this problem when I use the > >wxListCtrl (from wxJS) object in a script. All other scripts works fine. It > >has something to do with strings, but I can't demonstrate it with another > >script. From now on I use JS_GC before JS_DestroyContext. > > > > Thanks to Franky for providing a reduced testcase, which helped show the > culprit (old code dating back to the JSObjectOps.enumerate hook's > implementation and bugfix cycle -- when was that? I was working on > mozilla.org, I believe this was something fur did for LiveConnect3). > > Thanks also to Phil for filing bug > http://bugzilla.mozilla.org/show_bug.cgi?id=193393. I've attached a > patch there. Shaver likes the patch, so unless it doesn't test well for > someone, I'll check it into 1.4alpha when the trunk opens. Anyone using > current or RC5-era source, please give the patch a try if you can. > > /be > > > > >Franky. > > > > > > > > > .