Subj : Re: latest stable SpiderMonkey source version
To   : Shanti Rao
From : Brendan Eich
Date : Tue Apr 05 2005 12:02 am

Shanti Rao wrote:

> The following changes have been made to SpiderMonkey:
> 
> 1. Add parenthesis around ambiguous shift operators.


Shift operator precedence is not ambiguous in C, it's just arguably 
broken.  I generally overparenthesize.  Are these changes available as a 
patch to land so you don't have to keep redoing this?


> 2. Insert before jsobj.c#2503
>      lasbobj = obj = cx->fp->scopeChain;
>      if (obj)


This null check is not necessary, no matter what compiler you use.  Did 
you see my comment in https://bugzilla.mozilla.org/show_bug.cgi?id=233023 ?


> 3. Disable __declspec(dllimport) in jstypes.h
> 4. Replace JSLL_INIT macros in prmjtime.c and jslong.c


Can we get some Borland-friendly ifdefs in a patch for these items, so 
people don't have to keep redoing this?

/be

.