Subj : Re: Too permissive semicolon insertion?
To   : Igor Bukanov
From : Brendan Eich
Date : Sun Aug 22 2004 12:48 pm

This is a multi-part message in MIME format.
--------------020509010300070703020306
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Igor Bukanov wrote:
> 
> Is it a bug or some compatibility consideration?

Just a bug, fixed on the cvs trunk now.  Thanks for reporting it -- the 
patch is attached to this message for those who want to apply it to an 
older release (it should apply cleanly to very old releases, as the bug 
is ancient).

/be

--------------020509010300070703020306
Content-Type: text/x-patch;
 name="jsparse.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="jsparse.patch"

Index: jsparse.c
===================================================================
RCS file: /cvsroot/mozilla/js/src/jsparse.c,v
retrieving revision 3.105
diff -p -u -8 -r3.105 jsparse.c
--- jsparse.c	19 Aug 2004 17:57:36 -0000	3.105
+++ jsparse.c	22 Aug 2004 18:49:58 -0000
@@ -2766,17 +2766,17 @@ MemberExpr(JSContext *cx, JSTokenStream 
 
             if (!ArgumentList(cx, ts, tc, pn2))
                 return NULL;
             if (pn2->pn_count > ARGC_LIMIT) {
                 JS_ReportErrorNumber(cx, js_GetErrorMessage, NULL,
                                      JSMSG_TOO_MANY_FUN_ARGS);
                 return NULL;
             }
-            pn2->pn_pos.end = PN_LAST(pn2)->pn_pos.end;
+            pn2->pn_pos.end = CURRENT_TOKEN(ts).pos.end;
         } else {
             js_UngetToken(ts);
             return pn;
         }
 
         pn = pn2;
     }
     if (tt == TOK_ERROR)

--------------020509010300070703020306--

.