Subj : JS_malloc - nit-picking
To   : netscape.public.mozilla.jseng
From : S. Raza
Date : Sun Jun 13 2004 08:23 pm

JS_malloc in jsapi.c increments a runtime's malloc'd bytes prior to 
calling malloc and checking whether a null pointer was returned.

     cx->runtime->gcMallocBytes += nbytes;
     p = malloc(nbytes);
     if (!p)
         JS_ReportOutOfMemory(cx);

Should it be:
     p = malloc(nbytes);
     if (!p)
         JS_ReportOutOfMemory(cx);
     else
       cx->runtime->gcMallocBytes += nbytes;

-S

.