Subj : Re: Need a few hints on JS_CompileFunction
To   : Sterling Bates
From : Brendan Eich
Date : Tue May 18 2004 05:36 pm

Sterling Bates wrote:
> 
> WRT bug 243517, the patch for JS_CompileUCFunctionForPrincipals includes 
> a call to js_inflateString, then checks for a null (NULL?) result. Given 
> this, I should only inflate the string if strlen(name) > 0, correct?


No, you have to null-check name.  See the if (!name) {...} else {...} 
early on, just after the js_NewTokenStream call and return-value check.

Also, in the future, could you cvs diff all files at once, and attach a 
single patch-file?  Thanks.

/be

.