Subj : Re: spidermonkey docu
To   : Sterling Bates <whoelse.sterlingbates@com>
From : Brendan Eich <brendan@meer.net>
Date : Thu Apr 08 2004 07:01 pm

Sterling Bates wrote:
> "Brendan Eich" <brendan@meer.net> wrote in message
> news:40758E48.7080804@meer.net...
> Ok, fair point -- I was considering only correctness, but efficiency
> 
>>counts too, and the docs shouldn't mislead on that scale.
>>
>>More to fix.  Anyone want to try a patch for
>>http://lxr.mozilla.org/mozilla/source/js/docs/jsref.xml ?
> 
> 
> I've attached a change that might suffice.
> 
> Sterling
> 
> 
> 
> 1839c1839
> <       <C>JS_ValueToInt32</C> converts a specified JS value, <C>v</C>, to a JS double, and then to a 32-bit integer, if it fits. If the double is out of range, <C>JS_ValueToInt32</C> reports an error and conversion fails. The double rounded to the nearest integer value.<P/>
> ---
> 
>>      <C>JS_ValueToInt32</C> converts a specified JS value, <C>v</C>, to a 32-bit integer. If <C>v</C> is not a valid number, <C>JS_ValueToInt32</C> reports an error and conversion fails. A double is rounded to the nearest integer value.<P/>

You want to keep the part about out of range, perhaps specifying the 
range of a 32-bit signed integer. Saying "not a valid number" does not 
mean the same thing -- if anything, it means v is a NaN.

Also, can you attach patches in a separate MIME part with the right MIME 
type (text/plain, I guess)?  Thanks,

/be

.