Subj : Re: Regular expressions, bug 85721 To : zack-weg@gmx.de From : Brendan Eich Date : Wed Oct 22 2003 01:01 am zack-weg@gmx.de wrote: > Hi, > > Is there any chance to get the regexp rewrite in bug 85721 in? There > are a lot of bugs blocked by it. It isn't just a performance issue. > Some regular expressions give wrong results, some crash, even quite > simple expressions like /(?=a|b)|c/.test("") (bug 187133). > > There's a patch lying around for months. It may cause some regressions > (in fact I found a small one (see comment 81) but I doubt they will be > worse than the current behavior without the patch. > > http://bugzilla.mozilla.org/show_bug.cgi?id=85721 I checked in a version of the patch tweaked to fix the case you point out in comment 81, and to fix the warnings scole points out in comment 83, for Mozilla 1.6alpha. Thanks for reminding me about this bug, and rogerl's work in it. Please file new bugs on any remaining issues, performance or correctness. /be .