Subj : Re: The new changes to atom safety in garbage collection To : Brendan Eich From : "Steven C. Cole" Date : Thu Jul 31 2003 11:43 am Brendan Eich wrote: > That's a great idea -- thanks. We just need the resolve code in > js_LookupProperty to farble rt->gcKeepAtoms. I'm hopeful that's the > last place, but I haven't checked. If you know of other cases where > JSClass or JSObjectOps callbacks might be unable to trigger a GC without > collecting an atom in use, hit me. > > /be I only know about the resolve hook because that's where we got hit. (And our work-around was to always do a keep-atoms GC, so nothing else surfaced.) There certainly might be other places where atoms need to be protected --- I was hoping you or another Spidermonkey jockey might have a better feel for where that might be. I'll try out your patch (it's certainly simple enough; has my r= if you want it...). If testing shows any other spots that need the protection, I'll be sure to let you know! --scole .