Subj : Re: js_GetArgument To : Brendan Eich From : Phil Schwartau Date : Mon Jun 09 2003 04:01 pm We now have two regression tests for this bug: mozilla/js/tests/js1_5/Scope/regress-208496-001.js mozilla/js/tests/js1_5/Scope/regress-208496-002.js I renamed mozilla/js/tests/js1_5/Scope/regress-208496.js as regress-208496-001.js, and added regress-208496-002.js. The new test, again from Itaj, checks access of static properties of |f| from inside the |with(f)| block. Phil Brendan Eich wrote: > itaj sherman wrote: > >> i tried it. >> and i think it misses something else now - inside the with it overrides >> static members on the function. >> >> > > Right you are. I was playing with two approaches and forgot to cover > that case with the final change that landed. (The other approach was > too general -- it involved a new SPROP_ flag -- and touched too many > files). Fixed by rev 1.345 of jsobj.c. Thanks again. > > Phil, can you cover all the cases in the testsuite? Thanks. > > /be > .