Subj : Re: automatic variable that holds JSAtom* in JS_DefineFunction() To : itaj sherman From : Brendan Eich Date : Mon Mar 17 2003 03:07 pm itaj sherman wrote: >>JS_PUBLIC_API(JSObject *) >>JS_NewScriptObject(JSContext *cx, JSScript *script) >>{ >> JSObject *obj; >> >> /* >> * We use a dummy stack frame to protect the script from a GC caused >> * by debugger-hook execution. >> * >> * XXX We really need a way to manage local roots and such more >> * XXX automatically, at which point we can remove this one-off hack >> * XXX and others within the engine. See bug 40757 for discussion. >> */ >> JSStackFrame dummy; >> >>If it doesn't, you need to upgrade your engine. >> >> > >all the versions i use have this > Good, thanks for checking. >i always have JS_PARANOID_REQUEST, even added CHECK_REQUEST() to some >JS_*() that didn't have it like JS_SetPrivate() (and others, i can't >remember now). - BTW in some of the versions that i downloaded, there >were CHECK_REQUEST(cx) in some JS_*() that didn't have 'cx' parameter >(think JS_GetStringBytes) and i had to remove these lines. > Those were all fixed pretty quickly. What version of the cvs sources are you using? You probably should ride the trunk, at this point. /be .