Subj : Re: Software Job Market Myths To : comp.programming,comp.software-eng From : Baxter Date : Tue Aug 16 2005 08:55 pm One question I would ask is - how can we be sure that the combined lengths of s1 and s2 are less than the size of buf (256)? Then I would note that the function is returning a pointer to a temporary (stack) variable - which means the return value is going to go away the next function call made in the program. -- --------------------------------------------------------------------- DataGet & PocketLog www.dataget.com Data Collectors www.baxcode.com -------------------------------------------------------------------- "Chris Sonnack" wrote in message news:m5s4g19937nipakeq7e8l7gcslr599023m@4ax.com... > > It's a little bit like asking a supposed C programmer about this: > > char* strconcat(char* s1, char* s2) > { > char buf[256]; > > strcpy(buf, s1); > strcat(buf, s2); > > return buf; > } > > If they don't have *something* meaningful to say immediately, they > probably aren't the sort of C programmer we'd want. :-| .