Subj : Revisions ... To : Gerald Miller From : Jasen Betts Date : Mon Oct 21 2002 06:57 am Hi Gerald. 18-Oct-02 22:29:36, Gerald Miller wrote to Jasen Betts GM> @REPLY: 3:640/531.42 3ce61e63 GM> @MSGID: 1:342/512 3db0ee31 GM> @CHRS: CP437 2 GM> @TZUTC: -0600 GM> Hello Jasen, GM> On Thursday October 17 2002 at 18:09, GM> Jasen Betts [3:640/531.42] wrote to Gerald Miller, GM> about: Revisions ... JB>> (this is a "style flame" feel free tyo ignore it) GM> I choose not to ignore... GM>>> === Cut Begin: XBOOT2.BTM === JB>> the first potential problem I see with this BTM is that it uses JB>> variables that start with underscores (_) variables that begin with JB>> underscores are a bad idea when using 4dos as future versions of 4dos JB>> may have them as internal variables. GM> Valid point. Accepted. Revision: removed all underscores (_) from GM> variable GM> names EXCEPT 4dos internal variables, i.e. %_row, %_batchname JB>> I'll let you know what I find after I get it running without errors, JB>> (so far I've found three errors that stop it from running here: JB>> pipes in the data file, an %= escape in a ` quote, and the date JB>> format) Ok now it's running. GM> Oooops. Okay, I admit to the pipe character in exchange of the "³" GM> character, GM> but didn't know about not being permitted to use "%=" within a quote GM> (trying to GM> prevent wordwrap truncation) and GW> require clarification about your error of the date format the dates in the data file were not compatible with the date format here and causing errors etc.. once I editied that it started to work. GM>>> and obtain the "NEXT RUN" value, which I had tried to do in the GM>>> INCLUDE subroutine. I found that it wasn't quite as simple... JB>> It is that simple. GM> Just maybe.... Went to the ":INCLUDE" subroutine. Ammended to: GM> === *** === GM> :include GM> set i=%@inc[%i] GM> set run%i=%prog GM> set nextdate=%@date[%@eval[%@date[%today] + %when]] GM> return GM> === *** === GM> I then went to the line(s): GM> === *** === GM> iff "%ask" eq "N" .or. "%ask" eq "" then GM> gosub include GM> echo %@format[-41.41,%prog]³%@format[-10.10,%when]³%= GM> %@makedate[%today]³%@makedate[%nextdate]³%ask >> %temp (that's one of the echo lines) GM> endiff GM> elseiff "%prog" ne "" then GM> echo %@format[-41.41,%prog]³%@format[-10.10,%when]³%last%= ³ ³%ask >>> %temp (another one) I made that mistake forst time. right here it deletes nextdate again. GM> I then ran the BTM. It looks promising.... JB>> It maay be easier if you first but first you should split the echo JB>> that writes to the data file off into a subroutine instead of having JB>> it repeated 4 times. GM> I'm sorry, I'm not understanding your intent. Would you explain in more GM> detail and/or example nextdate is being read from the file as " " which 4dos shortens to "" so you'll need to use a %format or something when you copy lines to the temp file, you'll probably have seen what I mean by now. Bye. --- * Origin: "Qvid me anxivs svm?" (3:640/531.42) .