Subj : Test
To   : Tommi Koivula
From : Carlos Navarro
Date : Sun Feb 04 2024 21:36:48

27 Jan 2024 20:23:35 +0100 Carlos Navarro -> Tommi Koivula:

 CN> This may be a possible way to fix the corrupted From field in headers:
 CN> in nntpserv.c, instead of just removing this line:

 CN>   strcpy(mimefrom,&mimefrom[6]);

 CN> Replace it by:

 CN>   memmove(mimefrom,mimefrom+6,strlen(mimefrom)-5);

 CN> There could also be issues with the Subject field. The next line:

 CN>   strcpy(mimesubj,&mimesubj[9]);

 CN> could be changed to:

 CN>   memmove(mimesubj,mimesubj+9,strlen(mimesubj)-8);

 CN> As for the corruption in the body of messages posted with newsreaders
 CN> that support flowed text (like Thunderbird), I think it may be fixed by
 CN> changing this:

 CN>   strcpy(line,&line[1]);

 CN> to this:

 CN>   memmove(line,line+1,strlen(line));

 CN> These patches are for both JamNNTPd and SmapiNNTPd.

To prevent other potential problems, it is also convenient to do these other modifications in nntpserv.c:

Change every occurrence (there are 3) of:
 strcpy(article,&article[1]);
to:
 memmove(article,article+1,strlen(article));

Change:
 strcpy(from,&from[1]);
to:
 memmove(from,from+1,strlen(from));

Change:
 strcpy(subject,&subject[4]);
to:
 memmove(subject,subject+4,strlen(subject)+3);

And change:
 strcpy(text,&text[c]);
to:
 memmove(text,text+c,strlen(text)+c-1);

Carlos

--- Sylpheed 3.7.0 (GTK+ 2.24.30; i686-pc-mingw32)
 * Origin: cyberiada-NNTP (2:341/234.99)

.