Subj : New Defects reported by C To : cov-scan@synchro.net From : scan-admin@coverity.com Date : Mon Oct 28 2024 12:49:00 Hi, Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan. 1 new defect(s) introduced to Synchronet found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s) ** CID 511447: Control flow issues (DEADCODE) /js_bbs.cpp: 2334 in js_xfer_prot_menu(JSContext *, unsigned int, unsigned long *)() ________________________________________________________________________________________________________ *** CID 511447: Control flow issues (DEADCODE) /js_bbs.cpp: 2334 in js_xfer_prot_menu(JSContext *, unsigned int, unsigned long *)() 2328 if((sbbs=js_GetPrivate(cx, JS_THIS_OBJECT(cx, arglist)))==NULL) 2329 return(JS_FALSE); 2330 2331 if(argc > 0 && argv[0] == JSVAL_TRUE) 2332 xfer_type = XFER_BATCH_UPLOAD; 2333 if(argc > 1 && argv[1] == JSVAL_TRUE) >>> CID 511447: Control flow issues (DEADCODE) >>> Execution cannot reach the expression "XFER_BATCH_UPLOAD" inside this statement: "xfer_type = ((xfer_type == ...". 2334 xfer_type = (xfer_type == XFER_UPLOAD) ? XFER_BATCH_UPLOAD : XFER_BATCH_DOWNLOAD; 2335 2336 rc=JS_SUSPENDREQUEST(cx); 2337 sbbs->xfer_prot_menu(xfer_type, &sbbs->useron, keys, sizeof keys); 2338 JSString* js_str = JS_NewStringCopyZ(cx, keys); 2339 if(js_str == nullptr) ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu4gdQbQRNsarCbK0jIoVQSWT2zCPijRqaed4AhLiEI9Z7MR9SJQ09ot5XPbn9SW-2F14-3DITFI_7FYjIqE8olEh4k02KWtt1r1LGSyuXVEtCuKuJCXgAQaq5jE-2BLt6d0xDUmd9IA4TiFW4D2c-2Fv2LVaAIklYCEHPyQvUq2Zlw7GDvJu3j8LRmS7SAP5K0MN-2FeHPuzVDlzgYGLGR7UoaRyivmdwaD-2F8GGj2SeuFl5CNmO4uJ75M69NpIJcEgiKbpoWpXeuJdzQYzNm1WuI45zNZnbxNBPzaHrg-3D-3D --- þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net .