Subj : New Defects reported by Coverity Scan for Synchronet
To   : All
From : scan-admin@coverity.com
Date : Mon Mar 10 2025 15:09:45

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 544155:  Error handling issues  (CHECKED_RETURN)
/ssl.c: 540 in get_ssl_cert()


________________________________________________________________________________________________________
*** CID 544155:  Error handling issues  (CHECKED_RETURN)
/ssl.c: 540 in get_ssl_cert()
534     	size_t backoff_ms = 1;
535     	unsigned loops = 0;
536     	while (cert_entry->cert == -1) {
537     		assert_pthread_mutex_lock(&get_ssl_cert_mutex);
538     		/* Get the certificate... first try loading it from a file... */
539     		if (cryptStatusOK(cryptKeysetOpen(&ssl_keyset, CRYPT_UNUSED, CRYPT_KEYSET_FILE, cert_path, CRYPT_KEYOPT_READONLY))) {
>>>     CID 544155:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "log_cryptlib_error" without checking return value (as is done elsewhere 16 out of 17 times).
540     			DO("getting private key", ssl_keyset, cryptGetPrivateKey(ssl_keyset, &cert_entry->cert, CRYPT_KEYID_NAME, "ssl_cert", cfg->sys_pass));
541     			cryptKeysetClose(ssl_keyset);
542     		}
543     		if (cert_entry->cert == -1) {
544     			lprintf(LOG_WARNING, "Failed to open/read TLS certificate: %s", cert_path);
545     			if (cfg->create_self_signed_cert) {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



---
 þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

.