Subj : New Defects reported by Coverity Scan for Synchronet To : All From : scan-admin@coverity.com Date : Sun Mar 02 2025 15:12:36 Hi, Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan. 2 new defect(s) introduced to Synchronet found with Coverity Scan. 17 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 543172: Program hangs (SLEEP) ________________________________________________________________________________________________________ *** CID 543172: Program hangs (SLEEP) /main.cpp: 3876 in sbbs_t::~sbbs_t()() 3870 fremove(WHERE, syspage_semfile); 3871 3872 /********************************/ 3873 /* Free allocated class members */ 3874 /********************************/ 3875 >>> CID 543172: Program hangs (SLEEP) >>> Call to "js_cleanup" might sleep while holding lock "this->nodefile_mutex". 3876 js_cleanup(); 3877 3878 /* Reset text.dat */ 3879 3880 for (i = 0; i < TOTAL_TEXT; i++) 3881 if (text[i] != text_sav[i]) { ** CID 543171: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 543171: Null pointer dereferences (FORWARD_NULL) /main.cpp: 1528 in sbbs_t::js_create_user_objects(JSContext *, JSObject *)() 1522 bool sbbs_t::js_create_user_objects(JSContext* cx, JSObject* glob) 1523 { 1524 bool result = false; 1525 if (cx != NULL) { 1526 JS_BEGINREQUEST(cx); 1527 if (!js_CreateUserObjects(cx, glob, &cfg, &useron, &client, startup == NULL ? NULL :startup->web_file_vpath_prefix, subscan, mqtt)) >>> CID 543171: Null pointer dereferences (FORWARD_NULL) >>> "errprintf" dereferences null "this->startup". 1528 errprintf(LOG_ERR, WHERE, "!JavaScript ERROR creating user objects"); 1529 else 1530 result = true; 1531 JS_ENDREQUEST(cx); 1532 } 1533 return result; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview --- þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net .