Subj : New Defects reported by Coverity Scan for Synchronet
To   : All
From : scan-admin@coverity.com
Date : Fri Jan 24 2025 14:15:30

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 531895:  Integer handling issues  (INTEGER_OVERFLOW)
/tmp/sbbs-Jan-24-2025/src/conio/bitmap_con.c: 783 in draw_char_row_slow()


________________________________________________________________________________________________________
*** CID 531895:  Integer handling issues  (INTEGER_OVERFLOW)
/tmp/sbbs-Jan-24-2025/src/conio/bitmap_con.c: 783 in draw_char_row_slow()
777
778     	uint8_t fb = cs->font[cs->fontoffset];
779     	for(unsigned x = 0; x < vstat.charwidth; x++) {
780     		unsigned bitnum = x & 0x07;
781     		if (bs->expand && x == bs->font_data_width) {
782     			if (cs->gexpand)
>>>     CID 531895:  Integer handling issues  (INTEGER_OVERFLOW)
>>>     Expression "x - 1U", where "x" is known to be equal to 0, underflows the type of "x - 1U", which is type "unsigned int".
783     				fbb = cs->font[cs->fontoffset - 1] & (0x80 >> ((x - 1) & 7));
784     			else
785     				fbb = 0;
786     		}
787     		else {
788     			if (bitnum == 0 && x != 0) {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



---
 þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

.