Subj : src/xpdev/link_list.c link_list.h To : Git commit to main/sbbs/master From : Rob Swindell (on Debian Linux) Date : Wed Jan 22 2025 13:59:12 https://gitlab.synchro.net/main/sbbs/-/commit/31c010080e7c0d643f8b1975 Modified Files: src/xpdev/link_list.c link_list.h Log Message: Add/use new function: listAddNodeWithFlags() Fixes race condition/possible crash in listAddNodeData(), listAddNodeString() and listAddNodeList(). These functions were modifying the node->flags *after* a node was added to the list and list lock released. This is most likely the cause of the issue caught by valgrind when running the jsexec-testsuite: https://gitlab.synchro.net/main/sbbs/-/jobs/498286 Thank you Deuce and valgrind, nice catch! --- þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net .