Subj : New Defects reported by Coverity Scan for Synchronet
To   : cov-scan@synchro.net
From : scan-admin@coverity.com
Date : Mon Jan 20 2025 16:22:38

Hi,

Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.

1 new defect(s) introduced to Synchronet found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 530902:    (CHECKED_RETURN)
/useredit.cpp: 745 in sbbs_t::user_config(user_t *)()
/useredit.cpp: 740 in sbbs_t::user_config(user_t *)()


________________________________________________________________________________________________________
*** CID 530902:    (CHECKED_RETURN)
/useredit.cpp: 745 in sbbs_t::user_config(user_t *)()
739     		exec_bin(cmdline, &main_csi);
740     		getuserdat(&cfg, user);
741     		return;
742     	}
743     	while (online) {
744     		CLS;
>>>     CID 530902:    (CHECKED_RETURN)
>>>     Calling "getuserdat" without checking return value (as is done elsewhere 83 out of 98 times).
745     		getuserdat(&cfg, user);
746     		bprintf(text[UserDefaultsHdr], user->alias, user->number);
747     		if (user == &useron) {
748     			update_nodeterm();
749     			load_user_text();
750     		}
/useredit.cpp: 740 in sbbs_t::user_config(user_t *)()
734
735     	action = NODE_DFLT;
736     	if (cfg.usercfg_mod[0]) {
737     		char cmdline[256];
738     		snprintf(cmdline, sizeof(cmdline), "%s %u", cfg.usercfg_mod, user->number);
739     		exec_bin(cmdline, &main_csi);
>>>     CID 530902:    (CHECKED_RETURN)
>>>     Calling "getuserdat" without checking return value (as is done elsewhere 83 out of 98 times).
740     		getuserdat(&cfg, user);
741     		return;
742     	}
743     	while (online) {
744     		CLS;
745     		getuserdat(&cfg, user);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/synchronet?tab=overview



---
 þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

.